dagster
dagster copied to clipboard
Fix helper webserver command
Summary & Motivation
Helm rendering has a breaking indentation, making Dagster incompatible with programmtic synthetization tools like cdk8s https://github.com/cdk8s-team/cdk8s/issues/1679
How I Tested These Changes
Create a values-valid.yaml
ingress:
apiVersion: 'networking.k8s.io/v1/Ingress'
enabled: true
ingressClassName: nginx
dagsterWebserver:
host: '$hostname'
Execute helm template:
helm template . --values values-valid.yaml --debug > debug.yaml
With PR fix, indentation is probably rendered in deployment-webserver.yaml
@smackesey Please, can you take a look at this change?
I'm tagging you because you already reviewed this similar PR: https://github.com/dagster-io/dagster/pull/20126
Thanks in advance!