dagster icon indicating copy to clipboard operation
dagster copied to clipboard

(bugfix) make resources work with observe()

Open dpeng817 opened this issue 1 year ago • 1 comments

observe() currently doesn't work when you have resources required on the observable asset, despite there being a resources arg. This is because build_assets_job expects a fully resolved list of resource definitions, which observe() relies on the Definitions object to provide. Fix by switching to define_asset_job.

How I tested this Added a test that explicitly adds resource requirements to the observable source asset. Went from failing to not failing after this change.

dpeng817 avatar Feb 08 '24 23:02 dpeng817

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

dpeng817 avatar Feb 08 '24 23:02 dpeng817