dagster
dagster copied to clipboard
smtp auth user vs email_from
Summary & Motivation
Some email servers, such as AWS SES, require a separate authentication user from the email from address. But the make_email_on_run_failure_sensor() utility requires them to be the same.
This PR is a small change to allow specifying them separately. Backwards compatibility with previous behavior is maintained by defaulting the auth user to the email from address.
This PR also incorporates the fix from PR #16585 to return the sensor skip reason.
How I Tested These Changes
I tested the change with the latest dagster release, sending emails from both AWS SES (which requires separate auth user vs email from) and Gmail (which doesn't).
@yuhan noticed that these were functionalities you added a few years ago, would you be up to review this?
Apologies, I've fixed the ruff format error that caused the failure below.
Really useful functionality. looking forward to implementation.
Hello, any options that it will be implemented? Thanks.
While handling the merge conflict, I realized a similar commit was merged a few days ago: https://github.com/dagster-io/dagster/commit/774d1d3ded5263b95f201ba5f239fb66f51bc9d5. Therefore, I’ll be closing this.
Thank you for your effort in submitting this contribution, and I apologize for any inconvenience caused by the timing. This fell through the cracks because I lost track of this open PR.