Daniel Gröger

Results 20 comments of Daniel Gröger

@wagenet Thanks for merging my changes :) Maybe we can get someone else to test this as well. I know it's been some time but maybe @beddueimpossibile or @bartocc are...

@bartocc I tested it using a new dummy project, which I put here: https://github.com/dagroe/test-ember-sourcemaps The breakpoint in `components/test/foo-bar.ts` was hit using vscode with this `launch.json`: ```json { // Use IntelliSense...

Thanks for your PR :) Works fine for me when using `wagenet/ember-cli-htmlbars#fix-colocated-template-sourcemaps`. Source maps look correct in browser debug (firefox and chrome) and work as expected in VSCode. Also making...

@chriskrycho @rwjblue @dfreeman sorry for the ping but I am not sure who to ask for a review of this. Could anyone of you do it or assign someone? Thanks!

That would be a big drawback 😞 , but it seems to make sense that generating sourcemaps with `hires: true` for all colocated components will slow down the build. I...

Seems generating the source map is straight forward. I added it here: https://github.com/dagroe/ember-cli-htmlbars/tree/try-custom-sourcemap-generation @wagenet can you give this a try to see if it still works and improves build times...

@wagenet Seems source maps are fixed in `6.2.0`, at least for me they are working again without this PR.

@phil-davis Could you review this pull request or assign someone?

Dear maintainers, could anyone review this pull request please? 😄 @DeepDiver1975 @Henni @jancborchardt @tomneedham

I added a quick/temporary solution (see a pull request)