dagger icon indicating copy to clipboard operation
dagger copied to clipboard

feat: separate out enum names and values

Open jedevc opened this issue 11 months ago • 1 comments

Fixes https://github.com/dagger/dagger/issues/8671 - the aim is to fix all the remaining little nits with enums that make them tricky to use (also wanting to unblock #8608).

TODO:

  • [x] Tidy up core enum names
  • [x] Improved withEnumMember API for enum members
  • [ ] Kick off migration from withEnumValue to withEnumMember in all SDKs
    • [x] Go
    • [x] Python
    • [ ] Typescript
  • [ ] Backwards compat (this is gonna be bit tricky)
    • [ ] Handle renamed types, ImageMediaType->ImageMediaTypes, EnumValueTypeDef->EnumMemberTypeDef
    • [ ] Ensure that codegen for enums in dependencies stays the same
    • [x] Keep old TypeDef field EnumTypeDef.values
    • [x] Keep old core enum values (using member aliases)
    • [ ] Add new legacy tests
  • [ ] Fix inevitably broken tests
  • [ ] Clean up

jedevc avatar Feb 06 '25 13:02 jedevc

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 14 '25 02:03 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 29 '25 02:03 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Apr 05 '25 02:04 github-actions[bot]

I split some work out to #10058, so will rebase on that once merged.

jedevc avatar Apr 09 '25 10:04 jedevc

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Apr 24 '25 02:04 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 01 '25 02:05 github-actions[bot]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 22 '25 02:05 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar May 29 '25 02:05 github-actions[bot]

Will looking for Elixir within today✌️

wingyplus avatar Jun 12 '25 10:06 wingyplus