dagger icon indicating copy to clipboard operation
dagger copied to clipboard

tests: add retries to waiting for log output

Open sipsma opened this issue 1 year ago • 0 comments

Possibly fixes https://github.com/dagger/dagger/issues/7979 (to be confirmed in CI since that's the only place I can get it to happen).

I also am not sure yet if this is handling expected behavior more robustly vs. just avoiding a bug. If it's just avoiding a bug we shouldn't go with it.

Basically, I noticed that these flakes appear to just be cutting off the output while it's still being received. If you look in the logs you can see most of the expected output there but not all of it, which results in the error message expected not showing up.

cc @vito @jedevc on confirming whether it's expected that if you close a client while output is still being received then it is expected you might be cutting off some of the output, since you've worked on that whole are more than I

sipsma avatar Jul 19 '24 06:07 sipsma