dagger
dagger copied to clipboard
dagger
Test Dagger on Windows
Tests were broken on Mac #3433 and #3437, due to Path/Symlink differences between OS and versions.
Related to #3012 Reminder to check that the current version of Dagger works on Windows.
This issue is coming to a greater head w/ the engine image and local binaries. We need to explicitly choose whether or not we want to package helper windows binaries (or dagger-engine-session as it will be renamed soon) inside the engine image.
If we don't, dagger will not be usable on Windows at all to start (whereas previously it might have been sort of usable even if it was completely untested).
The main limiting factor in this is that we need to test it on Windows. I personally don't have a windows machine, so I can't even do manual testing without setting up a VM and such.
cc @aluzzardi @shykes something to be aware of for the upcoming release.
I think we should. It makes sense at least on paper. I can't speak to difficulties of testing & packaging, which may lead to implementation tradeoffs.
by the way, something just occurred to me. In the future, we could add to the engine API itself the ability to send the correct helper to the client. so, instead of having to pull the image itself, run it, and extracting the binary via docker, the client could instead connect to the engine, and then simply download the correct helper.
I think we should. It makes sense at least on paper. I can't speak to difficulties of testing & packaging, which may lead to implementation tradeoffs.
I'm going to add this to the Python 0.1.0 milestone in that case so it's not forgotten. cc @helderco
by the way, something just occurred to me. In the future, we could add to the engine API itself the ability to send the correct helper to the client.
I thought about that earlier too, but it also means that to get a helper binary you need a running engine, so if the helper binary is doing the provisioning of the engine then it's a catch 22. Either way, not practical in the short term, can be explored in the longer term though for sure.
@samalba @shykes since this didn't make it as part of the python release - who should we assign this to, so we can make sure it is completed?
cc @matipan @gerhard - found this one while looking through some of our old issues.
Once the migration to the new workers is complete, it would be really nice to have some windows ci workers as well - potentially happy to pick that up myself, not sure if we're tracking it somewhere in linear already?
