dagger-for-github icon indicating copy to clipboard operation
dagger-for-github copied to clipboard

🧪 Handle `version` inputs that start with `v`

Open jpadams opened this issue 8 months ago • 3 comments

curl -sL https://dl.dagger.io/dagger/install.sh 2>/dev/null | \
        DAGGER_VERSION='v0.9.2' sh
sh debug downloading files into /var/folders/s4/xyj9q5ps2ys3rc9nsps1v20m0000gn/T/tmp.tTShNB7AUU
sh debug http_download https://dl.dagger.io/dagger/releases/v0.9.2/dagger_vv0.9.2_darwin_arm64.tar.gz
sh debug http_download_curl received HTTP status 403

errors out because of extra v. Could be solved be removing the v here or could also be fixed upstream in the installer script, which might be better.

jpadams avatar Nov 15 '23 21:11 jpadams

I have raised an MR to fix this in the install.sh script, https://github.com/dagger/dagger/pull/7010

purpleclay avatar Apr 04 '24 05:04 purpleclay

@jpadams just to let you know, my fix to the install script has been merged in. So, in theory, this ticket could be closed?

purpleclay avatar Apr 04 '24 15:04 purpleclay

yup, we should do a release to get this fix into the hands of users - I had the same issue :)

lukemarsden avatar Apr 10 '24 11:04 lukemarsden