Feda Curic

Results 36 comments of Feda Curic

#3201 is closed so this can be unblocked I think.

Are we thinking that we for example don't pass `ensemble_config` to `load_parameters`, but instead only pass whatever is needed? https://github.com/equinor/ert/blob/863a5300d5774b9e4f9b18cb807f3ceac440c859/src/ert/analysis/_es_update.py#L84-L86

> Yes, or internalize the ensemble_config in `enkf_fs`, did something like that here: https://github.com/equinor/ert/pull/3807/files#diff-27f3b09264880e596302715e448e947ccf3e1a8d88396fd546eb90dd3a0480ac, but not completed. Is the goal of that PR (#3807) to close this issue?

#3201 is closed so this can be unblocked I think.

Did a quick search for `CONTAINER` in your branch and got two hits, on in `config_keys.hpp` and one in `enkf_types.hpp`. I think we can get rid of those as well.

Could these be added to for example the dict `simulation_arguments`? https://github.com/equinor/ert/blob/431aea8f40fd65a233f63842806be554aa048542/src/ert/shared/models/base_run_model.py#L62

ERT should now be ready for this, so do try and rebase. Let us know if you need assistance.