Daeyeon Jeong comments

Repositories
Issues
Comments

Results 24 comments of


                                            Daeyeon Jeong

src: add UV_PIPE_NO_TRUNCATE for bind in pipe_wrap.cc

There was a [test](https://github.com/nodejs/node/compare/fb5aa124ec127f838d9f26b7c9ac9d217edbd26a..d798da42d50e5e989b9e3f2e6ceda46c103ac11a), but it seems to be accidentally deleted. Please add it again.

NAPI: Add Symbols invisible to getOwnPropertySymbols

> Looking at the v8 and SpiderMonkey headers, both engines don't seem to have support for this, but maybe it could be added? Node.js core has used `v8::Private` to hide...

NAPI: Add Symbols invisible to getOwnPropertySymbols

/cc @nodejs/node-api Can we allow this kind of feature on Node APIs? It seems like a use case worth considering.

build: fix --v8-lite-mode build

Rebased the latest main and all tests are green. Please review once more. @anonrig @lpinca @richardlau