dae icon indicating copy to clipboard operation
dae copied to clipboard

chore/docs: enable cgo as much as possible

Open mzz2017 opened this issue 1 year ago • 8 comments

Background

根据 #557 所述,应尽量开启 CGO。对于跨平台移植性,使用 static link 来保证。因此检查 musl-gcc 和 zig 的可用性并调整 CC 进行 static link。

Checklist

  • [ ] The Pull Request has been fully tested
  • [ ] There's an entry in the CHANGELOGS
  • [ ] There is a user-facing docs PR against https://github.com/daeuniverse/dae

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #557

Test Result

mzz2017 avatar Jun 24 '24 18:06 mzz2017

Forgive my frankness, but this PR is adding unprecedented complexity to the build. For proprietary builds of various distributions, using CGO is a given fact. This PR wants to cover all possible CGO builds, which doesn't seem very necessary. I think it's unnecessary to make a big fuss over a rare DNS resolution issue; a document explanation or emphasis would suffice.

douglarek avatar Jun 27 '24 02:06 douglarek

@douglarek 从用户的角度来说,如果没有安装两个工具,行为是和之前一样的,不是强制的。只是尽量在工具存在的情况下绕过glibc进行静态编译

mzz2017 avatar Jun 27 '24 04:06 mzz2017

@douglarek CGO_ENABLED=0 可能会带来其他潜在问题,另外由关闭 cgo 导致的 dns 解析失败的问题很难排查,考虑到用户的环境复杂度,使用 libc 而不是 pure go 实现将问题复杂度从用户转移给更为专业的打包者我认为是可接受的。 欢迎大家进行讨论,特别是用户和打包者等不同角色的参与。

mzz2017 avatar Jun 27 '24 04:06 mzz2017

另外由关闭 cgo 导致的 dns 解析失败的问题很难排查

How about outputting whether a cgo is enabled in the version information? like this:

dae version 0.7.0rc1.r5.g64ebfea
go runtime go1.22.4 linux/amd64
CGO: enabled
Copyright (c) 2022-2024 @daeuniverse
License GNU AGPLv3 <https://github.com/daeuniverse/dae/blob/main/LICENSE>

if not:

dae version 0.7.0rc1.r5.g64ebfea
go runtime go1.22.4 linux/amd64
CGO: disabled (perhaps it will cause some dns issues)
Copyright (c) 2022-2024 @daeuniverse
License GNU AGPLv3 <https://github.com/daeuniverse/dae/blob/main/LICENSE>

douglarek avatar Jun 27 '24 06:06 douglarek

@douglarek What about the following compromise:

  1. Only statically link in CI/Dockerfile instead of make manually
  2. Revert related modification in Makefile
  3. Use musl-cross for static link instead of zig cc
  4. Give a docs to explain how to statically link

mzz2017 avatar Jun 29 '24 03:06 mzz2017

Only statically link in CI/Dockerfile instead of make manually

I think this is quite good; the binary released by the project can make such guarantees. However, when it comes to users compiling on their own, they can decide for themselves. ~~For actual distribution packaging, relying on glibc to enable cgo is a very normal operation.~~

douglarek avatar Jun 29 '24 09:06 douglarek

Numb, it seems that enabling CGO on amd64 causes node domain name resolution issues.

CGO_ENABLED=1 BUILD_ARGS="-buildmode=pie -modcacherw" CFLAGS="-fno-stack-protector" make VERSION="${pkgver}"

level=info msg="Include config files: [/etc/dae/config.dae]"
level=info msg="Loading eBPF programs and maps into the kernel..."
level=info msg="The loading process takes about 120MB free memory, which will be released after loading. Insufficient memory will cause loading failure."
level=info msg="Loaded eBPF programs and maps"
level=info msg="Bind to LAN: docker0"
level=info msg="Bind to LAN: virbr0"
level=info msg="Bind to WAN: enp5s0"
level=info msg="failed to parse node: create hy2://[email protected]: lookup a.b.c: Temporary failure in name resolution"
level=info msg="Group "final" node list:"
level=info msg="        <Empty>"
level=info msg="Group "us" node list:"
level=info msg="        <Empty>"
level=info msg="Routing match set len: 26/64"

douglarek avatar Jun 29 '24 10:06 douglarek

Numb, it seems that enabling CGO on amd64 causes node domain name resolution issues.

reproduced on my machine

st0nie avatar Jan 14 '25 16:01 st0nie