Mark Clark

Results 34 comments of Mark Clark

I can't tell you which is best practice but the idea is that you expose the 'open' boolean (via event, rootscope, or valueProvider) from your PageslideController so the container's parent's...

@nickperkinslondon I won't merge this tonight. If you do get a chance to review, that would be awesome. Let me know if you have any reservations. I'll probably merge this...

Jumped back to work, then holidays. Will resume in the near future.

Directives should still be functional in AngularJS 1.6+ What issues are you experiencing?

Just to consolidate the discussion here: I am currently working though old PRs and issues. I fully intend to investigate adding modern angular support but it will be a while...

A release/tag has been added to the repo. Will look into addressing the outdated builds mentioned by @stevenvachon.

This is being addressed by #104 pending a few changes. May make sense to have two different modes as well: highlight vs checkbox. Will give this more thought.

@mkretz Sorry for tagging you on such an old PR. The changes look good, I just need you to re-transpile the js file before this can be merged.

Couldn't this be achieved by just expanding the branch from the on-select handler passed into the directive?

@hualuomoli This is a good feature; however, it appears that it is 'always on'. In order to merge this it will need to be disabled by default and enabled by...