Daenney
Daenney
Mmm, come to think of it, I haven't seen this test fail recently. I wonder if we accidentally fixed something :smile:.
At first glance, it looks right, but I'll take a closer look. I'd want some tests for the `allowedGroups` function though before we merge this, covering the base cases of...
Meh, still bugs. It's easy to reproduce with `go test ./internal/paging -count 100 -run 'TestPage'`. If I switch to `-count 10` then it's a bit hit and miss if I...
Unless there's a merge conflict or you're actually changing something, there's no need to constantly push rebases of your changes. This creates a lot of notification noise for us, despite...
I think this looks good. The collection bits is honestly going a little over my head.
Overall this looks pretty great. I have some small stylistic/markup changes and once those get resolved I think this should be good to go! You can see the rendered result...
No worries, it's the weekend! We'll be here all of next week :wink:.
I'll leave it open for a day or two so the rest of the team has the opportunity to go through it too. If it doesn't get merged by anyone...
I'm going to close this for now. As Tobi mentioned, we're not targetting environments where this is a concern. This is also something that can be solved by an admin...
GtS has supported external authentication providers for a long time and it's not otherwise come up as an issue. That makes the argument that "everyone needs this" neitheer compelling nor...