Barun Acharya

Results 207 comments of Barun Acharya
trafficstars

> The only addition I see in what you're saying is.. To also recommend a list of deployments which requires automountServiceAccountToken: false. Right! Not mounting at all is more secure...

Noting we should consider using https://github.com/spf13/viper, it can help us accept configuration from not only just from flags but from env, yaml, json, toml....

Thanks a lot for taking this up @AvineshTripathi !

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not...

Sorry, I am not sure how the earlier pings got missed

Let me try it locally, the changes look mostly great. Can you squash the commits meanwhile?

Please don't apologise, our fault for not reviewing it for long. Take your time, Always appreciate your contribution

Run legacy uninstall after uninstall regardless of installation type