Daehan

Results 8 comments of Daehan

This is indeed hurting small pool operator's pool performance. Since this directly affects decentralization of Cardano network, we should definitely address this issue. In my opinion, this should have higher...

Since crypto/bip32.py is being implemented and maintained by PyCardano project contributers, I think this module should be included in the coverage report in my opinion. What do you think @cffls...

# Major Updates * Ensuring Mnemonic package generated entropy value is stored as a string representation * Pull out seed generating method for reusability * Setting `from_entropy()` passphrase parameter as...

Hi @henryyuanheng-wang , I have a question regarding `test_payment_address_12_reward2()` test case. For this test, I see that you are explicitly specifying `private=False` for the last two derivation path indexes. From...

Hi @henryyuanheng-wang, > Hi @daehan-koreapool , thanks for catching the inconsistencies and for making some great improvements! Everything looks pretty good. I like how you simplified the derivation step so...

I think the coverage test is failing since we are now including bip32.py module in the coverage report. I'll add more testcases try to increase the test coverage.

Added a bit more refactoring commits as well. * Pulled out frequently used list as a constant set. This could be set as a tuple if we want immutability, but...

FYI, the main branch now enforces stronger type hint in the Github ci/cd pipeline. I would advise rebasing this branch on top of the latest main branch to ensure the...