FastExpressionCompiler icon indicating copy to clipboard operation
FastExpressionCompiler copied to clipboard

Remove GetTypeInfo calls

Open Bykiev opened this issue 6 months ago • 9 comments
trafficstars

This PR removes GetTypeInfo calls, which improves performance

Bykiev avatar Apr 29 '25 18:04 Bykiev

@Bykiev Thank you for removing the TypeInfos. Good riddance. I will merge it later when I've done with #468.

dadhi avatar Apr 30 '25 15:04 dadhi

Ok, let's merge it now, when I am to start the work over for #468.

dadhi avatar Apr 30 '25 15:04 dadhi

@Bykiev Builds are failed, could you check.

dadhi avatar Apr 30 '25 15:04 dadhi

Can you please help with running tests in FEC in VS? I see there is TestRunner project, but how to run them with VS? There is no tests in VS test explorer

Bykiev avatar Apr 30 '25 15:04 Bykiev

Converted into draft for now... It seems I was wrong type.GetProperties(BindingFlags.DeclaredOnly); is equal to these binding flags: BindingFlags.Public | BindingFlags.Instance | BindingFlags.Static | BindingFlags.DeclaredOnly | BindingFlags.NonPublic and if all of them is specified the performance will be about the same. To gain some more performance specific flags should be specified.

Bykiev avatar Apr 30 '25 17:04 Bykiev

@Bykiev Yeah, I would look later.

To run the tests there are 2 TestRunner projects. You can run the build.bat to run everything which mimics the CI. Or run more quickish bt.bat and b.bat to run the tests only on the selected platforms.

dadhi avatar Apr 30 '25 17:04 dadhi

@dadhi, should be ok now, can you please rerun tests on CI?

Bykiev avatar Apr 30 '25 17:04 Bykiev

@Bykiev Let's keep this PR open, because don't like that there is no performance gain, but the code size is even bigger. At least, to make it concise, the flags can be combined once and put into constants. I will check later after #468.

dadhi avatar May 02 '25 12:05 dadhi

The performance still should be better, let's measure it

Bykiev avatar May 05 '25 06:05 Bykiev

Outdated. Sorry to close.

dadhi avatar Oct 18 '25 12:10 dadhi