FastExpressionCompiler icon indicating copy to clipboard operation
FastExpressionCompiler copied to clipboard

Published 20 hours ago • verified publisher icon dadhi

Make AutoMapper FEC branch to pass all the tests

Open dadhi opened this issue 4 years ago • 7 comments

The branch: https://github.com/AutoMapper/AutoMapper/tree/FastExpressionCompiler

dadhi avatar Aug 31 '19 16:08 dadhi

Baseline:

image

dadhi avatar Sep 30 '19 06:09 dadhi

image

jogibear9988 avatar Dec 17 '19 05:12 jogibear9988

The exception happens outside of running custom IL. Already generating crashes...

Also "dynamic" is used in some tests, don't think it is supported already?

jogibear9988 avatar Dec 17 '19 05:12 jogibear9988

Hi, what is the version did you check?

Dynamic is not supported (or rather is not tested)

dadhi avatar Dec 17 '19 08:12 dadhi

its the latest

jogibear9988 avatar Dec 17 '19 08:12 jogibear9988

Ok. Thanks for checking.

I have started work to fix AM some time ago - here is the updated branch in my fork https://github.com/dadhi/AutoMapper/tree/FECv3

The main problem is that AM expressions are big and complex, and composed in a multiple places - so I wanted to expect them with lately added LightExpression.ToCodeString. So I've started to switch AM from the System Expression to FEC.LightExpression and immediately stuck on the missing ExpressionVisitor support. So I've copied System ExpressionVisitor and started the conversion - it is currently in progress - I've pushed it as-is (does not compile yet) into the branch.

I am not sure when I can return back to this code because I have other things to finish.

dadhi avatar Dec 17 '19 13:12 dadhi

v3.1 update:

image

dadhi avatar May 04 '21 10:05 dadhi