rxr icon indicating copy to clipboard operation
rxr copied to clipboard

Reduce Import Scope & Ignore Undefined Returns from Reducers

Open wallzero opened this issue 9 years ago • 3 comments

Based on the following issue: https://github.com/dacz/rxr/issues/4

wallzero avatar Feb 23 '17 01:02 wallzero

Nevermind this still doesn't work. If the scan returns that state it also overwrites any states called by nested reducers.

wallzero avatar Feb 23 '17 02:02 wallzero

Tried using an || instead of storing the object but seems to only work some of the time; I'm guessing it depends on the order of the reducers in the scan. It be great if there was a way to have the scan itself skip returning an item.

wallzero avatar Feb 23 '17 02:02 wallzero

In the end I don't think this PR is going to resolve my issue. I think handling undefined is a good practice, but it seems if I don't return (state) > state, the scan will overwrite any changes to state by nested reducers. I've removed the undefined handler and now this PR is only about scoped imports. I'll continue comments in the issue ticket.

wallzero avatar Feb 23 '17 16:02 wallzero