David Cook

Results 50 issues of David Cook

#### What? Why? - Closes #12005 #### What should we test? - Visit ... page. - #### Release notes Changelog Category (reviewers may add a label for the release notes):...

We use Rubocop to standardise our code, which can improve code quality and reduce confusion. When evaluating each rule, consider if it helps with those goals or not. Often the...

epic
tech debt

We use the gem [rails/webpacker](https://github.com/rails/webpacker), which has been retired. Some of its dependencies already have [security warnings](https://github.com/openfoodfoundation/openfoodnetwork/security/dependabot) and can't be automatically updated (eg loader-utils), because webpacker locks to the older...

tech debt

I had to make assumptions based on the project files to work out what to do. It's not immediately clear for people like me who aren't familiar with this environment....

I've added these lines in `app/webpacker/controllers/index.js` as per the instructions: ``` import NestedForm from 'stimulus-rails-nested-form'; ... application.register('nested-form', NestedForm); ``` But getting this compilation error and don't know how to fix...

It's becoming really annoying! At first I thought it was after an update, but it happens every day. Can this be prevented/improved?

customSelect will set a class .customSelectDisabled on a select element that is disabled on initialisation. But it doesn't listen for changes in the disabled/enabled state and add/remove the .customSelectDisabled class...

It's possible to have multiple overrides in a Deface::Override file (as proven here: #77), but not using the new DSL in a .deface file. I can see why it would...

Follow on from enabling split checkout and, - https://github.com/openfoodfoundation/openfoodnetwork/pull/10913 We've removed the legacy checkout code, but there are still 12 specs that have been disabled as `pending` and need to...

epic
tech debt