David Cook
David Cook
Hi @mkllnk , I'm asking you first because we originally discussed this together and hopefully it makes sense to you. Let me know if we should move to the forum....
Thanks for the discussion @mkllnk and @luisramos0. Based on the above, I've created a new issue for a path forward with event management: https://github.com/openfoodfoundation/openfoodnetwork/issues/10457 For this PR, I will avoid...
Sorry I requested review prematurely. This is now rebased, and all tests are green.
> Oops, I didn't get to review before the rebase but I'll do my best in retrospect. Sorry, that was a mistake in what I said. I just meant that...
Now ready for a second review. @luisramos0 I understand if you don't have time, but if you do, would you like to re-review?
Ready to test! Tested deployment on au-staging: https://semaphoreci.com/openfoodfoundation/openfoodnetwork-2/servers/au-staging
## 📚 Draft documentation See here: https://github.com/openfoodfoundation/ofn-UserGuide/issues/41#issuecomment-1473118352
ActiveMerchant was accidentally updated in #9850, which closed this PR. But it's been reverted (d5ae5c9af4), so I'm re-opening this PR. @filipefurtad0 has re-tested: > I could not reproduce the bug...
I'm glad you double-checked, thanks @filipefurtad0 ! Great work on documenting the findings. Looks like we need to be careful with this one.
### Payload format I've set up the proof of concept with a slightly different format to the above. Any issues? ``` { "id": "374e0a40-f1d4-410c-9dc3-965baddde66b", "at": "2023-02-07 17:12:45 +1100", "event": "order_cycle.opened",...