David Cook

Results 169 comments of David Cook

Hi @RachL , I'm not sure that it's possible to achieve this as desired. > We want to add a modal soft warning when users attempt to navigate away from...

@jameleu are you able to add any details here or confirm if I'm right?

Thanks jameleu. @RachL, would you support changing this issue to implement the basic browser popup?

@RachL There are two possible tasks we can do: 1. Attempt the designed modal. We can only cover some cases with this (as per [my comment](https://github.com/openfoodfoundation/openfoodnetwork/issues/11600#issuecomment-1839820800)) 2. Add a browser...

In general, popup blockers will block something that pops up without a user interaction. So I think either of the suggestions on this issue are fine. But the out of...

I've updated the description to use the basic browser popup instead of the designed popup.

This is due to the variant being invalid, a problem which would appear if you had updated that row, or edit it in the variant screen. I wasn't able to...

Actually that probably won't make a difference, so I wouldn't bother retesting. I've updated the estimate section, to make the solution clearer.

This issue is now unassigned and ready to start. Here is a work in progress that might be helpful to refer to: - https://github.com/openfoodfoundation/openfoodnetwork/pull/12404