pimcore-i18n icon indicating copy to clipboard operation
pimcore-i18n copied to clipboard

[Routing] Data Object Routes

Open aarongerig opened this issue 1 year ago • 3 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #163

This PR adds data object routes (Pimcore UrlSlugs) to the toolchain. It automatically generates alternate routes without the user's need to intervene.

@solverat I've opened the PR as draft, as I'm not quite sure if that's everything that needs to be done in order to cover the complete functionality the other route types already have. I'm glad if you could review and provide some feedback! I'll add documentation after the coding has been done... 😉

aarongerig avatar Dec 05 '24 10:12 aarongerig

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions[bot] avatar Dec 05 '24 10:12 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

aarongerig avatar Dec 05 '24 10:12 aarongerig

@solverat Got any feedback on this for me? :)

aarongerig avatar Jan 27 '25 09:01 aarongerig

@aarongerig Finaly i have some time to test it!

First things first: Thanks for your efforts! :muscle:

solverat avatar Mar 06 '25 13:03 solverat

@aarongerig, todo:

  • add note to upgrade.md (New Feature for 5.2.0)
  • rebase to latest
  • add documentation (new document in section "Route and Alternate Links Generation")

solverat avatar Mar 06 '25 13:03 solverat

@solverat Something weird happened during rebasing. I double checked the changes since my initial commit, which are applied correctly to my code base.

I added documentation as well as the addition to the upgrade notes.

Hope it's fine to merge like that – otherwise let me know!

aarongerig avatar Mar 12 '25 16:03 aarongerig