node-cache-manager-ioredis icon indicating copy to clipboard operation
node-cache-manager-ioredis copied to clipboard

Published 20 hours ago • verified publisher icon dabroek

Upgrade to ioredis 5

Open phoenix741 opened this issue 2 years ago • 4 comments

Hi,

Can you upgrade to ioredis 5.* ?

Thanks

phoenix741 avatar Jul 04 '22 13:07 phoenix741

Can you describe what issues you have encountered using this package out of the box and/or why specifically you are looking for support for ioredis 5.* ?

From what I understand this just uses get/set, so I'm curious as to your situation.

kenzik avatar Jul 30 '22 02:07 kenzik

In our project team we have the policy to update libraries (and nodejs) to latest version to ensure to be always up to date, have all corrections, and vulnerabilities fixes.

More, in a project that depends of ioredis and "node-cache-manager-ioredis" having two version of ioredis increase the bundle by having two version of a library server side (ie: when using lambda).

ioredis 4.* is already 6 months old.

We don't encounter issue at today.

phoenix741 avatar Jul 30 '22 08:07 phoenix741

Hi @phoenix741 Did a rewrite of this package with ioredis@latest here: https://www.npmjs.com/package/@tirke/node-cache-manager-ioredis

Tirke avatar Aug 09 '22 07:08 Tirke

personally, I'd just remove the direct dependency on ioredis and make the External Redis Instance configuration pattern mandatory.

It makes dependency-management far simpler, and at worse, only adds about 2 extra lines of code.

schmod avatar Oct 04 '22 15:10 schmod