Dave Abrahams
Dave Abrahams
@adevress ping.
@Metalymph this looks like valuable work. Do you think we can move this PR forward and get it merged soon so the value isn't lost?
@kyouko-taiga I'm sorry I don't understand what @Metalymph is saying. Perhaps you know how to sort this out?
@lucteo please either move this PR forward or close it; thanks.
I'm not sure whether hylo's source base should try to satisfy `SwiftLint` or not; there should probably be a discussion and a review of its advice on the entire codebase...
The goal is to make something that's roughly an english phrase, or just fall back to noun labels if you can't. If it were up to me I would use...
FWIW, to me this ``` let e = try state.expect("type expression", parsedWith: parseExpr(in:)) ``` says , “I expect that "type expression" (was) parsed successfully with `parseExpr(in:)`”
> You mean that "parsed expression" is the input of `parseExpr(in:)`? I don't think I mean that. I don't see "parsed expression" anywhere in anything either of us wrote before....
@lucteo let's try to move open PRs forward and get them merged, or close them please.
@kyouko-taiga now that we're not really dependent on SPM anymore we should discuss whether this PR is going in the right direction and whether I should try to land it...