Dave Abrahams

Results 392 comments of Dave Abrahams

Yes I'm interested as to why you say that, but another thread please.

All newly added code should be covered by tests.

Update: prior setup-vsdevenv is still needed; otherwise we pick up the wrong `link.exe`.

Update: the problem was introduced between 0.2.2 and 0.2.3; upgrading to 0.2.2 is no problem for us. Apparently it has something to do with changes to "vs2002 compatibility setup"

> Does the problem go away if you add an additional, explicit call to gha-setup-vsdevenv with the default arguments, to replace the implicit call that was removed? I could try...

Without line numbers for the issues, I can't make head or tail of the errors.

> On Sep 17, 2024, at 11:44 PM, Dimi Racordon ***@***.***> wrote: > > there is no formal argument for accepting the function above but not the one from the...

To put it differently, it could be reduced to just `sink`, but then we'd have the wrong default. You'd be writing a lot of `sink var`s and few `sink`s.

Now I'm starting to understand one possible reason for the date stamp: [github won't replace an existing cache with the same key](https://github.com/actions/cache/issues/342#issuecomment-1399247646), which they don't warn us about. But then...

> there are reports about problems especially when actions run in parallel. Sure, if two jobs running in parallel try to write the same cache, there's a race condition. It...