linapple-pie icon indicating copy to clipboard operation
linapple-pie copied to clipboard

FTP file browser does not descend into directories

Open rhaleblian opened this issue 7 years ago • 13 comments

Immediately apparent when browsing asimov.net, since games are in genre directories.

Taking a look at it.

rhaleblian avatar Jan 15 '18 03:01 rhaleblian

Not caching for directories works fine. File requests still hit the cache. Makes for simpler code as well.

Two side notes:

  1. the single file in cache/ is named ftp.(null), which seemed odd. But probably irrelevant if you're not caching dirs.
  2. selected files drop next to cache/, not in it. Maybe that's by design.

rhaleblian avatar Jan 15 '18 04:01 rhaleblian

See https://github.com/dabonetn/linapple-pie/pull/3 .

rhaleblian avatar Jan 15 '18 05:01 rhaleblian

Ok, so I've compiled from your source and it still won't browse directories.

Did you test your code yet?

dabonetn avatar Feb 04 '18 02:02 dabonetn

Worked for me back in the day. Let's see what my mileage is these days.

rhaleblian avatar Jun 23 '18 17:06 rhaleblian

Still works. I checked that the existence of file cache/ftp.(null) from a previous session running master branch doesn't mess things up; it didn't for me but if you try again you might want to delete ftp.(null) first.

One error still persists -- the browser initially drops into the first subdirectory, 'action'. This error is in master as well.

Note: i had to make the dir cache in ftp myself, but you knew that, because if it's missing you'll get "Failure. Press any key!" in the browser.

rhaleblian avatar Jun 23 '18 18:06 rhaleblian

The binary I get, and the config:

https://drive.google.com/drive/folders/1gwYEt2PqrmX2Qt6myNA0-4M2Lg7SwWZm?usp=sharing

rhaleblian avatar Jun 23 '18 18:06 rhaleblian

Oh, the browser opens where you last downloaded a file, so the subdirectory start location is by design, not a bug.

rhaleblian avatar Jun 24 '18 14:06 rhaleblian

Mine wont get into directories, it always shows the first directory listing with the categories no mather what I click. The top of the screen shows the current directory, it descends to whatever I select while the list remains always the same. Deleting the ftp.(null) file does not change anything, it just recreates is and always lists first dir. Permissions on the dir are right, owner 'pi'.

I have noticed the ftp.(null) and thought thats the problem. Built from source, any ideas?

Zanop avatar Mar 09 '19 12:03 Zanop

Hi @Zanop , hmm i was recently wondering whether this was ok or not in mainline so i could decide what to do with my fork. When i can, i'll build from the same source you did; if it happens to me too i might have a fix for it after all.

rhaleblian avatar Mar 10 '19 21:03 rhaleblian

Hi @rhaleblian, I have submitted a fix, check out my pull request.

Zanop avatar Mar 11 '19 10:03 Zanop

I'll try to get to these soon, sorry, been tied up with real life lately.

dabonetn avatar Mar 11 '19 17:03 dabonetn

Me too, i might have time tonight.

rhaleblian avatar Mar 13 '19 22:03 rhaleblian

https://github.com/dabonetn/linapple-pie/pull/10 works, see comments.

rhaleblian avatar Mar 14 '19 05:03 rhaleblian