David Blain
David Blain
> This is really nice- finally had a chance to review it. @dabla - can you rebase it pleaase :) Thanks @potiuk just rebased it ;) and have a good...
> @dabla it would be great to add docs to explain what dialects are, what problem it solves and how to use it. Most of this information is already mentioned...
Following dependency check is failing in breeze: ``` pytest.param( ("providers/src/airflow/providers/standard/operators/bash.py",), { "selected-providers-list-as-string": "common.compat standard", "all-python-versions": "['3.9']", "all-python-versions-list-as-string": "3.9", "python-versions": "['3.9']", "python-versions-list-as-string": "3.9", "ci-image-build": "true", "prod-image-build": "false", "needs-helm-tests": "false", "run-tests": "true",...
> Following dependency check is failing in breeze: > > ``` > pytest.param( > ("providers/src/airflow/providers/standard/operators/bash.py",), > { > "selected-providers-list-as-string": "common.compat standard", > "all-python-versions": "['3.9']", > "all-python-versions-list-as-string": "3.9", > "python-versions": "['3.9']",...
> > @eladkal @potiuk This error is logical, as I needed to add the common sql provider dependency as the GenericTransfer needs this dependency due to the newly introduced SQLExecuteQueryTrigger...
> @dabla - I rebased it -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests....
@potiuk @eladkal Once [PR 45478](https://github.com/apache/airflow/pull/45478) is merged less files will be impacted here as I moved that extraction to a dedicated [PR](https://github.com/apache/airflow/pull/45478) to simplify the review of this one.
> > @potiuk Okay but this would then have an impact on imports no? Or would you keep same structure as is and move the GenericTransfer from standard providers to...
@potiuk @eladkal I still have breeze test failing for selected tests on main (why do we only test on main branch?) since I moved the generic transfer to common sql,...
> The root cause is here: https://github.com/apache/airflow/actions/runs/12743121090/job/35512486483?pr=44809 > > You need to run pre-commit with your change to regenerate .json file where we keep dependencies cross-providers. Ok my bad, how...