Results 30 comments of David Blain

> > It’s a bit hard to split as all modifications are linked to each other. I was already happy I was able to pull it off imho ☺️ >...

@potiuk What about this one? I've extracted 2 PR from it, the rest of the modifications are more difficult to extract into other PR as they are all linked... Af...

> > Af few providers are failing due to the get_extra_json method fom above #39811, which means those providers would be dependant on a newer Airflow version. > > We...

> > > Af few providers are failing due to the get_extra_json method fom above #39811, which means those providers would be dependant on a newer Airflow version. > >...

> @dabla - for this one we have to make sure that the tests are "compatible" with older versions of Airflow - because that is how we are testing compatibility...

I've remarked we had the same issue with SAP Hana and now also with MSSQL, so I started debugging and trying some stuff out. At the end I came up...

> @Taragolis , requesting your comments on this. > > I was working on updating `mssql` provider to use `sqlalchemy_url` property in `get_uri` and got the idea for this issue....

An overview of all enhancements and fixes I did regarding hooks: [40665](https://github.com/apache/airflow/pull/40665) [40669](https://github.com/apache/airflow/pull/40669) [40751](https://github.com/apache/airflow/pull/40751) [40836](https://github.com/apache/airflow/pull/40836) We already patched our Airflow production env with those changes and all works great.

> ### Description > Currently, we allow users to pass dialect via `sqlalchemy_scheme` extra field of the `mssql` connections. > > https://github.com/apache/airflow/blob/3873b098130ff4b8c1b8a37ac596be7b560c62ca/airflow/providers/microsoft/mssql/hooks/mssql.py#L80 > > I am proposing to remove this...

As [PR40669](https://github.com/apache/airflow/pull/40669) has been closed I think this one can also be closed?