OrgChart icon indicating copy to clipboard operation
OrgChart copied to clipboard

current scale calculation fix

Open filip0v opened this issue 8 years ago • 4 comments

Hi dabeng!

I corrected the calculation of the current zoom range, the current implementation does not work for all cases.

For example, for an element with the style transform: rotate (90deg) translateY (-100%) scale (2,2); an incorrect value is returned.

The thing is that the scale must be calculated from the transformation matrix according to the formula (matrix or matrix3d, not important):

scale = Math.sqrt (matrix[0] * matrix[0] + matrix[1] * matrix[1]);

jsfiddle for an example: https://jsfiddle.net/q4hjffwd/

Link with more detailed description about it: https://css-tricks.com/get-value-of-css-rotation-through-javascript/

filip0v avatar Nov 27 '17 11:11 filip0v

@dabeng, please consider my pull request

filip0v avatar Dec 05 '17 08:12 filip0v

Thanks a lot. I'm reviewing the PR 😊

dabeng avatar Dec 11 '17 03:12 dabeng

Hi @filip0v , could you review the Djave's comments at the end of the article you mentioned above?

dabeng avatar Dec 11 '17 07:12 dabeng

Hi @dabeng, I'll give an answer in a few days.

filip0v avatar Dec 14 '17 09:12 filip0v