react-express icon indicating copy to clipboard operation
react-express copied to clipboard

Highlight important parts in the code

Open vritant24 opened this issue 7 years ago • 1 comments

Would it be possible to highlight the parts in the code that are being focussed on in the section? A few times there is a lot of code including styles around the one or two lines of code that is being talked about. For example, in Rendering with ternary -

{subtitle ? (
          <h2 style={styles.subtitle}>{subtitle}</h2>
        ) : (
          <h3 style={styles.empty}>No subtitle</h3>
        )}

this is the part that should attract the reader's focus, but it blends in with 50 other lines of code.

vritant24 avatar Jun 25 '17 18:06 vritant24

This would be very helpful. It would go in the underlying project, react-native-web-player.

I can do this at some point, but in case somebody wants to take it, this is a good place to start: https://github.com/dabbott/react-native-web-player/blob/master/components/workspace/Workspace.js#L357. We would add something like a new selectedLines=[...] prop and a url param for it.

dabbott avatar Jun 25 '17 20:06 dabbott