advanced-shiny icon indicating copy to clipboard operation
advanced-shiny copied to clipboard
verified publisher icon daattali

Made busy-indicator work within modules

Open mmoisse opened this issue 6 years ago • 3 comments

Made busy-indicator work within modules, requires git version of shinyjs https://github.com/daattali/shinyjs/commit/8627e85f61f3535ea85f9409c7a86246daa2a203

mmoisse avatar Feb 27 '19 14:02 mmoisse

Was wrapping each input in its namespace the only thing required to do?

daattali avatar Feb 27 '19 17:02 daattali

Apart from using the latest shiny js which fix a bug when id is NULL, it is the only thing I changed

mmoisse avatar Mar 09 '19 22:03 mmoisse

In that case I would prefer to mention in the README that the input names need to be wrapped in the namespace function if used in a module, but the vast majority of people don't use modules and I think this code will add extra complexity/confusion. If I'm not mistaken, there's also a stackoverflow question about this (maybe you asked it?) so if the answer is on stackoverflow I think that's good enough.

I do appreciate you taking the time to make the PR

daattali avatar Mar 10 '19 00:03 daattali