Daan Huybrechs
Daan Huybrechs
> The `Base.isapprox` function tends to return strictly equality evaluations for exact numbers. For example: That is a funny example. So we have ```julia julia> b = rationalize(1.000000000000001) 750599937895084//750599937895083 julia>...
> Note that `≈` is not a transitive relation. This property cannot be avoided because of its tolerance. True. It's a little weirder than that because `1.0 == 1`, so...
Back on topic, I can't think of an argument in either direction for more general domains right now, as DomainSets also represents open and closedness explicitly (which makes it "discrete...
It seems I was relying on approximate comparisons between open and closed intervals in BasisFunctions.jl. Easily fixed, but somewhat annoying, because it is harder to create open and closed intervals...
To me `leftopen(0..1)` seems like a good option.
Good catch. There is a different [definition of hash](https://github.com/JuliaApproximation/DomainSets.jl/blob/a7770bbe51ec6a8bfebb0a975ed861bf18b6e92d/src/domains/interval.jl#L8) in DomainSets (which we should remove I suppose) which takes into account openness and so is correct for the first example,...
How about: ```julia hash(I::TypedEndpointsInterval, h::UInt) = isempty(I) ? hash(_interval_hash, h) : hash(isleftopen(I), hash(isrightopen(I), hash(leftendpoint(I), hash(rightendpoint(I), hash(_interval_hash, h))))) ``` It seems a unique variable `_interval_hash` is already defined, so for empty...
There are other possible ways of expressing this (all of which work for ranges): `Float64.(0..1)`, `convert(Domain{Float64}, 0..1)` or `map(Float64, 0..1)`.
Hmm, the broadcast and map syntax would need special support which isn't there, but I was expecting the convert syntax to work for units. It does not: ```julia julia> using...
> @daanhb This will have a big impact on DomainSets.jl. Speak now or forever hold your peace. I don't like deadlines on vacation :-) If this PR does have a...