homebase-app icon indicating copy to clipboard operation
homebase-app copied to clipboard

User search bars

Open fabiolalombardim opened this issue 1 year ago • 1 comments

Closes #851

fabiolalombardim avatar Jun 13 '24 14:06 fabiolalombardim

Deploy Preview for tezos-homebase ready!

Name Link
Latest commit d650d2d2a65a43a501268e35655cdea58f1e2139
Latest deploy log https://app.netlify.com/sites/tezos-homebase/deploys/67157627452f860008d221de
Deploy Preview https://deploy-preview-853--tezos-homebase.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 36 (🔴 down 4 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 54 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 13 '24 14:06 netlify[bot]

Screenshot 2024-10-21 at 02 34 50 The logic is still not working.

Man-Jain avatar Oct 20 '24 21:10 Man-Jain

If you go to a specific page on token list page. and then search for token not in that page the search doesn't work or doesn't show the token you're searching for. Even if it's there.

  1. Go to specific page
Screenshot 2024-10-21 at 02 37 41
  1. search for a token that exists. Screenshot 2024-10-21 at 02 37 51

Man-Jain avatar Oct 20 '24 21:10 Man-Jain

Screenshot 2024-10-21 at 02 34 50 The logic is still not working.

@Man-Jain This item appears in the list because the search considers the id, name, and symbol fields when processing the query. In this case, the name of the PNLP token is ‘SEB-PEPE PNLP’, which is why it shows up in the search results.

ashutoshpw avatar Oct 20 '24 21:10 ashutoshpw

Screenshot 2024-10-21 at 02 34 50 The logic is still not working.

@Man-Jain This item appears in the list because the search considers the id, name, and symbol fields when processing the query. In this case, the name of the PNLP token is ‘SEB-PEPE PNLP’, which is why it shows up in the search results.

Ohhh makes sense then. Alright.

Man-Jain avatar Oct 20 '24 21:10 Man-Jain

https://github.com/dOrgTech/homebase-app/pull/853#issuecomment-2425223895

If you go to a specific page on token list page. and then search for token not in that page the search doesn't work or doesn't show the token you're searching for. Even if it's there.

1. Go to specific page
Screenshot 2024-10-21 at 02 37 41
2. search for a token that exists.
Screenshot 2024-10-21 at 02 37 51

@Man-Jain This one is resolved now by resetting the page counter whenever user searches for something.

ashutoshpw avatar Oct 20 '24 21:10 ashutoshpw