[Enhancement] Enhancements for file and contact selection dialogs

[Kabouik]

I know it is annoying to have a single user who keeps adding items to his already long wishlist, but please see that just as ideas. You'll do whatever you feel is relevant with this:

• [ ] Multiple selection would be very useful for both contact and file selection dialogs. Done for attachments using external file picker like nnn, not possible yet with builtin selection menu and hence contacts.
• [ ] Allow invoking the file selection dialog when already in the export/save view (e/s) to allow selecting the destination folder before confirming the export/save with Return.
• [x] Done — File selection dialog could remember the last location after adding one attachment, by default within the same composed message, and globally as an option (i.e., remember_file_select_location=1). Not sure if quitting and relaunching nmail should reset that or if the location should still be remembered.
• [ ] Autocompletion with Tab in the file selection dialog (#44).
• [ ] Not directly related to those dialogs, but to the fields that the dialogs populate: support for Home, End, ^k, a-f, a-b, a-backspace, etc. in those fields would be useful. I did not test extensively, but it seems the fields support fewer keybindings than the base editor, which can be confusing. Or maybe typical bash keybindings to edit text like ^u to delete everything to the left, etc.? This would differ from the base editor keybindings though; probably even more confusing.
• [x] Done, not configurable — Navigating in and out of folders in the file selection dialog could be doable with the keys set in ui.conf for changing views in nmail, as long as those keys do not conflict with the filter directory/file feature (i.e., as long as those keys do not print characters in the filter field). This may be useful only to those who set their keys to something like KEY_LEFT and KEY_RIGHT though, so even though it would use the same muscle memory to navigate through nmail and through directories, I understand it might be too much work just for corner cases and a fraction of users.

[d99kris]

Thanks for the suggested improvements! I'll review them and see how to best address them. Don't worry about submitting ideas/suggestions, it's very valuable input. :+1:

[d99kris]

Regarding the last bullet "Navigating in and out of folders" it is as of 62c26bc possible using left/right keys (although not configurable).

The other bullet items have not been addressed yet.

[Kabouik]

Updated the first post. Let me know if things are irrelevant/not planned and I'll edit accordingly too.

[d99kris]

Thanks! Eventually as I go through them I might suggest to split them into separate Github issues (the ones I'm inclined to pursue). But at this discussion/suggestion stage it's fine as a single issue.

(from nmail v1.87 - test of latest reply-to fix)

On 2020-08-04 21:56 Kabouik [email protected] wrote:

Updated the first post. Let me know if things are irrelevant/not planned and I'll edit accordingly too.

--
You are receiving this because you were assigned. Reply to this email directly or view it on GitHub: https://github.com/d99kris/nmail/issues/47#issuecomment-668611332

[Kabouik]

The fifth point in the list is now partly covered by 557a1f7a1428af8dae02f7cb4cfbec5d1d64d3ca (#62). Do you want me to check it? The commit, however, does not add other common bash keybindings nor does it allow all current keybindings in text fields other than the compose field, but I don't know if you were planning on adding those features.

[d99kris]

Thanks for pointing out @Kabouik - but I think we can leave it unchecked for now.

Eventually I'm hoping nmail can support the full set of standard navigation/editing key bindings. But yeah, the development progress has been a bit slow lately.

[d99kris]

A partial fix, adding support for file selection dialog to remember last dir, has been implemented in 31006a3.

[d99kris]

Will proceed to close this issue, as the remaining tasks for it are covered by reported issues #44, #117 and #118.