sdmaid-se icon indicating copy to clipboard operation
sdmaid-se copied to clipboard

AppCleaner deletion slow 0.20.beta / root

Open DB9-max opened this issue 1 year ago • 8 comments

AppCleaner results deletion slow 0.20.beta / root. Few previous versions were slow too.

With shizuku is faster, but using root method as so many other apps doesn't use shizuku.

Smartphone (please complete the following information):

  • Device: Oneplus Nord
  • OS: A11
  • Root status: Rooted, Kitsune Mask (Magisk) 26.4
  • SD Maid 2/SE version: 0.20.beta

DB9-max avatar Feb 13 '24 19:02 DB9-max

Please provide a debug log, 🙏

d4rken avatar Feb 14 '24 10:02 d4rken

Now I tried with shizuku but it's still slow.

After appcleaner has scanned and then press delete (all items) there seems to be gap and gaps in starting deletion and between deleting items from different apps.

Deletion was faster in previous betas - I dunno about 4 months maybe I've used this and just recent releases have this occurance.

DB9-max avatar Feb 14 '24 20:02 DB9-max

I'm also facing the same issue with the last 2 builds. The same apps also keeps popping up during deletion and once it completes and if i scan again, the same size is shown. I'm using a oneplus 11. Maybe an issue with oneplus devices?

Update: Added logs. @d4rken eu.darken.sdmse DebugLog - v0.20.0-beta0 (2000000) ~ 9747173e_FOSS_BETA).zip

Device: Oneplus 11 Android version: 14 Steps: AppCleaner-> Scan-> Delete(takes ~25 min) -> Scan again. Shows the same size.

I went through the logs and could see that all the operations being timed out because it couldn't find the [Storage usage] target. Does SD Maid search for buttons with the text [Storage usage] or something?

aadithya96 avatar Feb 15 '24 08:02 aadithya96

For me it's just a minute or two longer, and that is significantly slower than what it used to. Appcleaner usually finds some 2-3 GB for deletion.

In SD Maid SE almost all cleaning options are selected in the 3 main cleaners.

DB9-max avatar Feb 15 '24 17:02 DB9-max

@aadithya96 Your device is not rooted and your issue is with the accessibility service. Moved here #1016

@G-D-B-9-9 Has a rooted device and does not need the accessibility service.

It's two different issues.

@G-D-B-9-9 I still need a debug log from you to look into it.

d4rken avatar Feb 16 '24 17:02 d4rken

Log here. Maybe it's not a big issue but apps behaviour changed like described. And I didn't see same kind of speed with shizuku as before. Since I've saterted using Sui as shizuku control. I don't if SD Maid SE uses it or not but granted in Sui anyhow.

eu.darken.sdmse_logfile_1708178085684.zip

DB9-max avatar Feb 17 '24 14:02 DB9-max

Sui https://github.com/RikkaApps/Sui

DB9-max avatar Feb 17 '24 14:02 DB9-max

Thanks for the log, I don't see a "bug", but I'm working through the log to see if there are any bottlenecks where I could improve performance.

d4rken avatar Feb 18 '24 18:02 d4rken

Is this still an issue? Has performance improved over the months?

d4rken avatar Aug 21 '24 12:08 d4rken

No really. Though I think I have accessibility service enabled. And Shizuku/Sui as alternative but I guess it uses root...

Corpse finder fast

System cleaner about fast

App cleaner slowish

But compared to such as App Manager's 1 click cache cleaner it's 2 seconds and done. But SDM2 every_time searches paths, files, names, sizes, times(?) and presents it to user.

Many times in app cleaner it's irrelevant. Shadercache and webcache. Cache. Cached, crypted, obfuscated, etc. Just plain junk.

Compared to system cleaner there's logs and other temp and cache actual readable and usable files.

Now that I think of it app cleaner deletion is quite somewhat fast - it's ok - but the indexing seems to take afully time.

Great app anyhow.

Feedback: History section if that could be turned off from settings?

Feedback2: If you leave SDM2 into background (searching) and go to another app - SDM2 often gets stopped and returns to the start page without results and have to press cleaner/s running again. I don't get it its lightweight but doesn't then feel like it. Maybe it's A11 there's no Material/you whatever.

DB9-max avatar Aug 22 '24 04:08 DB9-max

No really. Though I think I have accessibility service enabled. And Shizuku/Sui as alternative but I guess it uses root...

Ok I'll close the ticket. If specific issues come up, I'm sure I'll look into further performance improvements.

Corpse finder fast

System cleaner about fast

App cleaner slowish

AppCleaner is the most complex tool (except for SystemCleaner with many custom filters).

But compared to such as App Manager's 1 click cache cleaner it's 2 seconds and done. But SDM2 every_time searches paths, files, names, sizes, times(?) and presents it to user.

If we would restrict deletion to just default caches then it could be this fast too, but SD Maid isn't happy with 90% of the way, we want 99,99% thoroughness :grin: .

Now that I think of it app cleaner deletion is quite somewhat fast - it's ok - but the indexing seems to take afully time.

If you know a specific case, or app, that is processed much more slowly, feel free to open a new ticket (include a debug log).

Feedback: History section if that could be turned off from settings?

If you set the retention to 0 days, it should basically be "off".

Feedback2: If you leave SDM2 into background (searching) and go to another app - SDM2 often gets stopped and returns to the start page without results and have to press cleaner/s running again. I don't get it its lightweight but doesn't then feel like it. Maybe it's A11 there's no Material/you whatever.

That's up to the system unfortunately. It is lightweight, but depending on how many results there are, quite some memory is consumed, but this really depends on the ROM and RAM of a device.

d4rken avatar Aug 22 '24 15:08 d4rken