toolz icon indicating copy to clipboard operation
toolz copied to clipboard

Remove unused checks

Open ryanbr opened this issue 3 years ago • 3 comments

Just a review of the current toolz checks. When adding domains, are there example sites being used to reference against each check? Seems pointless adding a domain check if it's never used outside of https://d3ward.github.io/toolz/adblock.html

A few checks aren't actually used for tracking, people may link to these Twitter pages for example, but they're not tracking or ads.

https://blog.twitter.com/advertising
https://blog.twitter.com/marketing/en_us.html
https://blog.twitter.com/
https://advertising.twitter.com/

https://an.facebook.com/ shows no sites using it for tracking, no network blocks

Non-existent: ads-dev.pinterest.com -> https://publicwww.com/websites/%22ads-dev.pinterest.com%22/ d.reddit.com -> https://publicwww.com/websites/%22d.reddit.com%22/ hotjar-analytics.com -> https://publicwww.com/websites/%22hotjar-analytics.com%22/ api-hotjar.com -> https://publicwww.com/websites/%22api-hotjar.com%22/ amazonclix.com -> https://publicwww.com/websites/%22amazonclix.com%22/ amazonaax.com -> https://publicwww.com/websites/%22amazonaax.com%22/ advertising-api-eu.amazon.com -> https://publicwww.com/websites/%22advertising-api-eu.amazon.com%22/ affiliationjs.s3.amazonaws.com -> https://publicwww.com/websites/%22affiliationjs.s3.amazonaws.com%22/ analyticsengine.s3.amazonaws.com -> https://publicwww.com/websites/%22analyticsengine.s3.amazonaws.com%22/

The actual domain for fastclick.com is fastclick.net, fastclick.com isn't a legit ads/tracking domain. Checking the .net is all is needed.

ryanbr avatar Mar 28 '22 21:03 ryanbr

Hello @d3ward.. Just curious if any of these suggestions by @ryanbr are to be considered for future updates.. I know it's in Beta stages.. Would love to see the whole thing succeed.

RicoHeat avatar Jun 03 '22 00:06 RicoHeat

@RicoHeat Regarding adding these to Easylist or Easyprivacy. No. Adding domains that aren't actually used seems to be pointless. The benchmark should always be checking valid domains used on websites.

Until these invalid domains are removed, just avoid this "benchmark".

ryanbr avatar Jun 03 '22 01:06 ryanbr

Yes @RicoHeat , the changes will be included in V3 directly as stable . Still working on it since i want to make it almost perfect ! I think everyone will love it even more than current

d3ward avatar Jun 03 '22 07:06 d3ward

Domains removed on upcoming version 3.0.0 of toolz

d3ward avatar Feb 04 '23 10:02 d3ward