Mosaic icon indicating copy to clipboard operation
Mosaic copied to clipboard

Consider sending any useful changes upstream

Open danomatika opened this issue 4 years ago • 2 comments

I figure creating a single issue here is faster.

Howdy, nice project.

I see you needed to fork some of my addons: ofxGLEditor, ofxLua, ofxMidi. If you have the time, please consider porting required changes upstream via PRs etc and we can work towards having the project build without needing forks.

danomatika avatar Oct 19 '20 10:10 danomatika

Thanks and of course!

I'll check the code, clean it a little and push PRs to the respective addons.

ofxMidi was forked just in case, but i haven't changed anything, so i will switch to the original one in the readmes and in the Mosaic installer scripts.

ofxGLEditor just opened a PR with the only changes in my fork, a simple compile fix.

ofxLua is a little bit tricky, my fork is actually old ( from 2018 ) so i'll need to check your last code, and adapt my commits to create a proper PR. I'm away from work right now, so i'll do this when i'll be back in November.

d3cod3 avatar Oct 19 '20 19:10 d3cod3

Just updated references for ofxGLEditor and ofxMidi on READMEs and scripts, i'll work next week on ofxLua.

d3cod3 avatar Nov 01 '20 07:11 d3cod3

Just updated to your original repo of ofxLua, so no forks anymore!

d3cod3 avatar Nov 28 '22 10:11 d3cod3