d3-brush icon indicating copy to clipboard operation
d3-brush copied to clipboard

FF android

Open Fil opened this issue 4 years ago • 2 comments

on ff android vertical pan is a little janky - address bar keeps moving up and down. Same in v1 - not a regression or anything

(reported by @1wheel)

  • v1: https://observablehq.com/d/26c2fdd171873df0@270
  • v2: https://observablehq.com/@d3/mona-lisa-histogram

Fil avatar Aug 24 '20 06:08 Fil

Maybe a case of touch-action: none or touchStart.preventDefault ; see https://observablehq.com/d/8c6133113d33b60c

Fil avatar Aug 25 '20 13:08 Fil

tested on an Android phone this version seems good (fixing the issue both on Chrome and FF):

the difference is svg.on("touchstart", event => event.preventDefault())

I'm not sure if it should be added by default in d3-brush or left to the user.

Fil avatar Aug 26 '20 12:08 Fil