Publish on NonGNU ELPA?

[manuel-uberti]

Hi,

is there any interest in publishing this package on NonGNU Elpa? If so, may I suggest to get in touch with @phikal and see what can be done about it?

Of course, if there is no interest in such a thing feel free to close this issue and forget about it. :)

[d12frosted]

Hi Manuel,

If there is an interest in flyspell-correct on NonGNU Elpa, I will gladly work in that direction. I suspect it should be easy :)

On Thu, Oct 21, 2021 at 17:47, Manuel Uberti @.***> wrote:

Hi,

is there any interest in publishing this package on NonGNU Elpa? If so, may I suggest to get in touch with @.***(https://github.com/phikal) and see what can be done about it?

Of course, if there is no interest in such a thing feel free to close this issue and forget about it. :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[phikal]

It looks like it all works. If added now it would distribute 7b4cf8c9ba5ac65e3bb2b62f5b72d45f4c9cf7b6, so if you want a newer version you'd have to increment the version tag.

The other question is always could the code be added to ELPA, or if there is a copyright situation that would prevent that.

[manuel-uberti]

The other question is always could the code be added to ELPA, or if there is a copyright situation that would prevent that.

That's true. I suggested NonGNU ELPA to @d12frosted only because I don't know what every contributor to this package think about the copyright agreement. If there is nothing blocking on this side, I agree that ELPA is the better option.

[d12frosted]

@phikal @manuel-uberti I am ok with getting it to ELPA.

I don't know what every contributor to this package think about the copyright agreement

I also don't know what every other 14 contributors think. Does it mean that I need to ask them prior to making flyspell-correct available on ELPA? Or is it enough that from the day zero this package was using GPL?

[manuel-uberti]

I think you have to ask only to contributors who worked on more than 15 lines of code: https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html

[d12frosted]

Alright, so let's use this thread to ask every contributor if they are willing to go over copyright assignment process.

Please, each of mentioned person answer if you are willing to, already done or don't want to:

• [x] @d12frosted - willing to, not started
• [ ] @minad
• [x] @Boruch-Baum
• [ ] @gusbrs - blocked as can't have the FSF papers
• [ ] @clemera
• [x] @Ergus
• [ ] @tpadioleau

I will updating this message to reflect status in one simple view.

[phikal]

I belive you can tick minad, clemera and Ergus, because know they either contributed to core Emacs or ELPA.

On 25 October 2021 08:25:37 CEST, Boris Buliga @.***> wrote:

Alright, so let's use this thread to ask every contributor if they are willing to go over copyright assignment process.

Please, each of mentioned person answer if you are willing to, already done or don't want to:

• [ ] @minad
• [ ] @Boruch-Baum
• [ ] @gusbrs
• [ ] @clemera
• [ ] @Ergus
• [ ] @tpadioleau

I will updating this message to reflect status in one simple view.

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[gusbrs]

Hi @d12frosted , I'm sorry to be a problem on this, but I don't have, and can't have the FSF papers. I have tried, twice, to sign them, but unfortunately without success.

I have checked, and I have two commits contributed:

• https://github.com/d12frosted/flyspell-correct/commit/c9d264c5956732ecde9a44857a3d89ab8e10ef21: which is a one liner.
• https://github.com/d12frosted/flyspell-correct/commit/3e19a0c70293b6a0572bc72d5625201de1e0e09b: which has a larger diff, but which is mostly indentation change, due to the wrapping of a part of flyspell-correct-move in unwind-protect. But other than that is also a small diff.

I see two ways for this. One, perhaps these two commits, counted the lines which are not just whitespace change, fit the "tiny change" limit. And I think they do. Perhaps some adjustment to the second commit can be done so that this is clearer. The other would be to revert the two commits and replace them with equivalent code by someone else. I would not see any problem in it, and personally think flyspell-correct in GNU Elpa is a good thing. So I hate being the obstacle here, but believe me, it is not up to me.

[Boruch-Baum]

On 2021-10-24 23:38, phikal wrote:

I belive you can tick minad, clemera and Ergus, because know they either contributed to core Emacs or ELPA.

That sounds very wrong. Just because someone in the past agreed to contribute sixteen lines of foo to package foo.el doesn't mean they agree now to contribute sixteen lines of bar to package bar.el. Even if minad, clemera and Ergus have current copyright assignments registered with the FSF you should get an affirmation from each that said assignment will apply to flyspell-correct contributions. An exception would be if any of them assigned their contributions to Boris, in which case Boris's assignment would be sufficient.

Just as one possible practical example (there are many more), less than a year ago there was a movement of hundreds of individuals / projects / corporations signing petitions and making announcements cutting ties with the FSF. Some subset of them can be expected to have had in the past assigned copyright for their past contributions but would not want to assign further work. That's just one example, but there could be any number of situations. Any silent Alice (who did not back then 'cancel' the FSF) may agree to use her FSF assignment for contributions she makes to Bob's project but refuse to do so for her contributions to Mallory's project ... IANAL.

So IMO Boris is correct to ask, but should be asking the question a bit differently:

1. Are you willing to assign your flyspell-correct contributions?

2. Has your legal paperwork been successfully processed by the FSF?

For me, the answers to both questions are 'yes'.

On 25 October 2021 08:25:37 CEST, Boris Buliga @.***> wrote:

Alright, so let's use this thread to ask every contributor if they are willing to go over [copyright assignment][1] process. Please, each of mentioned person answer if you are willing to, already done or don't want to:

• [ ] @minad
• [ ] @Boruch-Baum
• [ ] @gusbrs
• [ ] @clemera
• [ ] @Ergus
• [ ] @tpadioleau

-- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0

[Ergus]

Hi:

I already have a copyright assignment.

[d12frosted]

@gusbrs thank you for your quick reply. Don't feel sorry, you are not a problem on this 😸 Quite the opposite, I am grateful for your contributions 💯

@phikal I am not familiar with the process here, so not sure how to proceed here. Any guidance, please 🙏 ?

[d12frosted]

@Ergus thank you!

[d12frosted]

@Boruch-Baum what you say makes total sense to me. But I am so far from politics and jurisprudence that I have nothing to comment on that. Thanks for sharing your thoughts! And many thanks for your answer for both of these questions 👍

[phikal]

@Boruch-Baum

That sounds very wrong. Just because someone in the past agreed to contribute sixteen lines of foo to package foo.el doesn't mean they agree now to contribute sixteen lines of bar to package bar.el.

To clarify: Knowing their past and recent contributions to Emacs and ELPA, I would strongly assume that they would be in favour of assigning their contributions to flyspell-correct to the FSF too. You are of course right that this is not automatic, I just wanted to indicate that the prospect of collecting all the copyright assignments looks good.

@phikal I am not familiar with the process here, so not sure how to proceed here. Any guidance, please pray ?

I would be inclined to agree that the indentation changes are not significant. The safest thing is to defer a final decision, and ask emacs-devel when proposing to add the package.

[Provessor]

There is interest on emacs-devel for getting (at least part of) this package into GNU ELPA.

@gusbrs has your situation with the copyright assignment changed? By my count you have made more than 15 lines of non-whitespace changes to flyspell-correct.el (though possibly not all of these will count as non-trivial changes). It seems you would be okay with replacing your contributions to get this into GNU ELPA but it would be best if that weren't necessary.

Thanks.

[d12frosted]

As far as I understand there are only two people without FSF papers - @gusbrs and @d12frosted. Since we kind of have a back up plan for @gusbrs, let me send my papers. And if they are accepted, we can proceed with contributions from @gusbrs.

[gusbrs]

@gusbrs has your situation with the copyright assignment changed?

Unfortunately, no. And there's no reason to expect the situation will change. (To be fair, I have never stated the situation was "pending" in any way, and was clear on it from the start). So, whatever you do here, you should proceed without my papers. As, I've said previously, I'd be glad myself to see flyspell-correct contributed to GNU Elpa, and I'd be fine with any changes regarding my contributions that may have to be made to see this through.

[d12frosted]

Alright, I've received my papers, but will be able to sign them only next week. Will keep you posted.

[Provessor]

@gusbrs I've been informed that lines "must express some real creative activity" to be counted towards the 15 line limit. In this case your contribution shouldn't pose an issue for inclusion to GNU ELPA (provided you haven't previously submitted code to a different GNU ELPA package, et. al.).

@d12frosted No rush

[gusbrs]

I've been informed that lines "must express some real creative activity" to be counted towards the 15 line limit. In this case your contribution shouldn't pose an issue for inclusion to GNU ELPA (provided you haven't previously submitted code to a different GNU ELPA package, et. al.).

@Provessor I do have a tiny change contribution to Org which, if it counts to the same "pool" for the 15 lines limit, would pretty much exhaust any such allowance for me here.

[Provessor]

I do have a tiny change contribution to Org which, if it counts to the same "pool" for the 15 lines limit, would pretty much exhaust any such allowance for me here.

@gusbrs I'll have a look for it, is "Gustavo Barros" down as the author?

[gusbrs]

@gusbrs I'll have a look for it, is "Gustavo Barros" down as the author?

Well, yes, but there's no need for you to trouble, I can tell you it was a 14 line commit. The only thing to check is whether they count into the same limit or not.

[Provessor]

I can tell you it was a 14 line commit

In that case we'll need to replace your lines here. I don't know the exact requirements for this, I'll find out and post a patch.

The only thing to check is whether they count into the same limit or not.

Yes it's cumulative.

This is a cumulative limit (e.g., three separate 5 line patches) over all your contributions.

[phikal]

Provessor @.***> writes:

I can tell you it was a 14 line commit

In that case we'll need to replace your lines here. I don't know the exact requirements for this, I'll find out and post a patch.

You first have to figure out how much of the code that Gustavo contributed is still used. I'd recommend removing it, and then trying to implement the same feature perhaps using some different approach.

Maybe this might help: https://www.gnu.org/prep/standards/standards.html#Reading-Non_002dFree-Code, talking about how to clone a Unix program for GNU:

If you have a vague recollection of the internals of a Unix program, this does not absolutely mean you can’t write an imitation of it, but do try to organize the imitation internally along different lines, because this is likely to make the details of the Unix version irrelevant and dissimilar to your results.

It might help to leave yourself some time between removing the code and re-implementing the functionality.

[d12frosted]

Alright, it turns out I could digitally sign the papers, so now I have completed my copyright assignment specifically for flyspell-correct source code.

[Provessor]

@d12frosted Great!

@phikal Thanks for the pointers.

[Provessor]

I have a patch which I think solves this, only problem is I leave the unwind-protect as it is the only reasonable way I know to preserve cleanup if the user C-g with some frontends. I wonder if it counts as creative input when said change is THE fix for such a problem.

EDIT: @gusbrs has 13 lines in org which means one here is still one line under the limit.

I'll count the org commit lines again to see if one line is a problem.

@d12frosted I assume you would prefer this as a PR?

[d12frosted]

@Provessor Amazing! PR or patch over email, both work for me.