Nathaniel Woodthorpe

Results 88 comments of Nathaniel Woodthorpe

Thanks for the report! I tried to reproduce, but I get logged out and sent back to our splash page as expected. When you reproduce, are you logged into GitHub.com,...

The solution here https://github.com/education/classroom-assistant/issues/103#issuecomment-570954993 resolves this issue, in a hacky way. I'll leave this issue open for now, Classroom Assistant should replace the remote after we finish cloning.

Is this still happening @sierrajulietromeo ?

Any movement on this? We can't distinguish between messages and threads which is causing problems.

Hey @donni106 , We underscore because that's the convention in Ruby when parsing GraphQL results. I can see the usecase for non-underscored results though, I can look into putting some...

I should be able to get to this in the next few days

This fell off my radar for a bit, I don't have a ton of time right now for non-functional or non-significant changes, but this should be an easy PR if...

Turns out we can unit test the loaders! c7d8bc4

Even though the loader is unit tested, I still think writing end-to-end integration tests would be a great idea.

Hey @SJTucker ! If I'm understanding correctly, you have a resolver that's doing something like this? ```ruby def foo(id:) MyLoader.load("users(id: [#{id}]) { ... }") end ``` This isn't something we...