dockerpty icon indicating copy to clipboard operation
dockerpty copied to clipboard

return exit code from exec_command()

Open akvadrako opened this issue 9 years ago • 2 comments

I would like to check that my commands succeed from my calling script. This small change allows that to happen.

akvadrako avatar Jun 29 '16 18:06 akvadrako

This looks alright as a default. It adds another API call to exec_command, but people can always avoid that by using the lower-level ExecOperation interface.

LGTM

aanand avatar Jun 29 '16 18:06 aanand

nicely done

looks like that SimpleQueue has different defintions on 2 and 3:

2

Init definition: SimpleQueue(self)

3

Init definition: SimpleQueue(self, *, ctx)

TomasTomecek avatar Jun 30 '16 07:06 TomasTomecek