GodMode9 icon indicating copy to clipboard operation
GodMode9 copied to clipboard

Published 20 hours ago • verified publisher icon d0k3

Fix compiling on non-UTF8 system, especially Windows

Open R-YaTian opened this issue 8 months ago • 5 comments
trafficstars

R-YaTian avatar Mar 25 '25 10:03 R-YaTian

May I suggest to split this PR since it contains changes for two different problems. Please don't mix.

eku avatar Mar 31 '25 08:03 eku

Still unsure about the py -3 change. We could of course take this over partially (only the UTF-8 fixes). I'm not working with Windows anymore, so I cannot test or even give an educated opinion on this on.

@Wolfvak - what do you think?

d0k3 avatar Apr 27 '25 10:04 d0k3

@Wolfvak - what do you think?

I think we can partially merge this, excluding the py -3 change.

Wolfvak avatar Apr 27 '25 20:04 Wolfvak

Alright. @R-YaTian - can you remove that change? Afterwards we'll merge it.

d0k3 avatar Apr 27 '25 21:04 d0k3

Alright. @R-YaTian - can you remove that change? Afterwards we'll merge it.

Done!

R-YaTian avatar Apr 28 '25 01:04 R-YaTian

.. merged.

d0k3 avatar Oct 07 '25 16:10 d0k3