d3planner icon indicating copy to clipboard operation
d3planner copied to clipboard

Suggestion: Embed on site

Open XpodX opened this issue 8 years ago • 3 comments

It would be so nice to have a embed d3planner on your web site. I Found this one but its not complete at all (no items no rolls etc). http://diablo3.judgehype.com/build/23951/

<iframe src="http://diablo3.judgehype.com/build-embed/23951/" name="D3BuilderFrame" id="D3BuilderFrame" width="645" height="775" style="border:0;background-color:#131313"></iframe>

I like your work. Keep it up.

XpodX avatar Jun 01 '16 02:06 XpodX

Sounds interesting, might require a lot of work though as it would have to re-use a large portion of the code.

d07RiV avatar Jun 06 '16 14:06 d07RiV

@d07RiV I haven't looked a lot yet through this project but have you considered a completely decoupled app? You already have a lot of the pure data publicly exposed at different routes: /skills etc. But I imagine reworking all the major code to be hosted as purely an API would be extremely time consuming. Not to mention the number of requests...yikes

jlhall avatar Nov 01 '16 20:11 jlhall

You mean for the iframe thing? There's almost no backend code, all the work is done via javascript so there isn't much to turn into an API.

d07RiV avatar Nov 01 '16 21:11 d07RiV