weird-erc20 icon indicating copy to clipboard operation
weird-erc20 copied to clipboard

Published 20 hours ago • verified publisher icon d-xo

Add a `TransferOwnership` use case

Open luislucena16 opened this issue 1 year ago • 7 comments

hey @d-xo I think it would be great to add an example related to ownership to validate that the direction the new control is taking is not a contract, what do you think? :)

luislucena16 avatar Feb 15 '24 12:02 luislucena16

@luislucena16 can i work on this issue?!

SIDHARTH20K4 avatar Feb 21 '24 15:02 SIDHARTH20K4

hey @SIDHARTH20K4 yes, no problem, you can do it! link the PR to this issue so we don't create another one! so we can review it :)

luislucena16 avatar Feb 22 '24 11:02 luislucena16

hey @SIDHARTH20K4 yes, no problem, you can do it! link the PR to this issue so we don't create another one! so we can review it :)

could you please elaborate the problem... so that I can I can work on it freely

SIDHARTH20K4 avatar Feb 22 '24 17:02 SIDHARTH20K4

@SIDHARTH20K4 I think you can make a simple deposit and withdraw contract that includes the transferOwnership and how this would be protected

luislucena16 avatar Feb 25 '24 22:02 luislucena16

I've created a PR kindly check it and let me know if everything is perfect! @d-xo

SIDHARTH20K4 avatar Feb 28 '24 16:02 SIDHARTH20K4

I left you some comments in the PR!

luislucena16 avatar Feb 28 '24 17:02 luislucena16

I left you some comments in the PR!

I've updated it!! Kindly check and let me know if averything is perfect!!

SIDHARTH20K4 avatar Feb 29 '24 14:02 SIDHARTH20K4