ngSmoothScroll icon indicating copy to clipboard operation
ngSmoothScroll copied to clipboard

Published 20 hours ago • verified publisher icon d-oliveros

smoothScroll as a service works in .js but not in min.js

Open santhotech opened this issue 9 years ago • 5 comments

I think the min.js file in this repo is broken. I saw an other issue complaining about scroll-to directive not working. The same case with me but with smoothScroll service in controller. If the lib/.js file is included it works, if the dist/.min.js file is included, it does not work.

santhotech avatar Feb 05 '16 18:02 santhotech

Just confirmed this. Was not working with the min. Switched to the other file and it worked right away.

iRoachie avatar Feb 09 '16 08:02 iRoachie

I also dealt with this problem, I tried to minify the file myself and found that it works. I will submit a pull request with the newly minified file.

dweitz43 avatar Feb 10 '16 20:02 dweitz43

#60

dweitz43 avatar Feb 12 '16 13:02 dweitz43

Same issue. Couldn't make it work with the min.js file, had to use the lib version

psegarel avatar Jul 08 '16 05:07 psegarel

@psegarel check this #60 not sure if it will ever be merged but it does allow you to use the minified source correctly

dweitz43 avatar Jul 08 '16 06:07 dweitz43