Diogo Netto comments

Results 50 comments of


                                            Diogo Netto

Canonicalize names of nested functions by keeping a more fine grained counter -- per (module, method name) pair

@vtjnash: I believe I addressed the remaining comments. Any additional requests? Good to merge?

Canonicalize names of nested functions by keeping a more fine grained counter -- per (module, method name) pair

> Plan to take a look at this over the weekend. Unfortunately was not able to meet this deadline. Apologies for the delay here.

Canonicalize names of nested functions by keeping a more fine grained counter -- per (module, method name) pair

Bump?

Canonicalize names of nested functions by keeping a more fine grained counter -- per (module, method name) pair

Bump?

Possible bug when constructing a string from an array of characters

Ah sorry, that's on our fork of Julia, which is a patched 1.10 (will edit the comment above to provide a clarification on that). But yes, the issue reproduces on...

Possible bug when constructing a string from an array of characters

RSS stays the same, just `live_bytes` increases. This makes sense if you take a look at `jl_gc_free_array`: ```C static void jl_gc_free_array(jl_array_t *a) JL_NOTSAFEPOINT { if (a->flags.how == 2) { char...

Move GC to its own directory and library

Bump.

Move GC to its own directory and library

> Shouldn't src/julia_gcext.h also be moved? Basically everything it defines is implemented in src/gc.c Possibly.

Move GC to its own directory and library

Final bump. Will merge on Thursday if no objections.

Move GC to its own directory and library

@nanosoldier `runbenchmarks(!"scalar", vs=":master")`