Diogo Netto
Diogo Netto
> across all modules Wrong since the counter is already per-module (grep for `fl_current_module_counter`). Still, as mentioned above, the proposed change would ensure that adding a nested function doesn't perturb...
> Could we use the bindings table to avoid needing this huge extra space? Not sure if I get it? The current implementation stores one extra hash table per module,...
Addressed most of the concerns raised above in the last commits. In particular: - Canonicalized names are no longer using `` or module names. They are using `##` to keep...
> The solution would seem to be either to: > - Add specific serialization support for counter_table to preserve it across the serialization boundary, OR > - Check in the...
> I'm not sure whether or not we actually delete bindings right now, but that seems like an unfortunate fragility. Yes, that's fair. Though if we plan on using the...
@JeffBezanson sent his OK on the approach described [here](https://github.com/JuliaLang/julia/pull/53719#discussion_r1589755765). @vtjnash, @topolarity: any further objections on merging this?
Yes, that's one source of confusion for me as well. As it is, it seems like `jl_array_to_string` is calling `jl_pchar_to_string` which does copy the array into the allocated string. For...
Three possible paths forward, actually, the third one being what you suggested: implement a function to free the buffer which has been moved and make sure it's correctly accounted in...
> I believe the issue is that ->maxsize shouldn't be reset Yes, this does solve https://github.com/JuliaLang/julia/issues/54275. Still, it's a bit odd that constructing a `String` from an `Array{UInt8}` takes ownership...