influxdb-cpp-rest
influxdb-cpp-rest copied to clipboard
d-led
CMake integration
Hi, would you accept a PR with CMake integration? I would like to use this as a third party library, but it is hard to integrate this repo as a submodule.
Sure. If you're willing to make a nuget/conan package, that would be great too. Try to get it working in both CI systems with CMake too.
I'm not a conan expert, although I'm using it for cpprestsdk. One of the problems that I've found out, is there's no "findCpprestsdk.cmake" file, so we can't do a find_package(cpprestsdk) easily (I think it will fail if we get cpprestsdk via conan)
Seems like v2.10.0 will support find_package. From the release notes:
- Added CMake config-file support to installation. This should be consumed by doing:
find_package(cpprestsdk REQUIRED)
target_link_libraries(my_executable PRIVATE cpprestsdk::cpprest)
I've forked this repo and will work on it :smile:
P.S. updated the submodules git submodule update --remote, in case you want to merge upstream
As far as I see, no breaking changes. I'll update my remote with this. I'll propose a PR for this issue within some days.
Hi, I'm really sorry for not doing the MR sooner. I found a problem with CppReskSDK: their FindXXX.cmake is not working properly when you use Conan; they fixed it on 2.10, but 2.10 is not yet available on conan packages by bincrafters (it's on testing branch). As a result, I was waiting for it to go stable in order to propose the MR.