vscode-code-review icon indicating copy to clipboard operation
vscode-code-review copied to clipboard

[feature] adopt comment-api

Open heartacker opened this issue 3 years ago • 3 comments

🧩 Feature

adopt comment api

Description

https://code.visualstudio.com/updates/v1_35#_comments-api

https://github.com/microsoft/vscode-extension-samples/tree/main/comment-sample

A clear and concise description of the feature

heartacker avatar Jan 26 '22 06:01 heartacker

look nice and it also looks like a selection of multiple lines can be made. For our review purposes marking "reviewed" areas is important

keesj-exset avatar Jan 26 '22 09:01 keesj-exset

I very much like that. We also stumbled upon this API in the last couple of days. It looks very nice and is used by other plugins as well (Atlassian plugin for instance).

I see two topics to be tackled, though, before starting any implementation:

  • How to integrate all the information that can currently be entered in the webview into this inline view? (name, description, category, priority)
  • How should the data model look like when multiple comments are added?

croesnick avatar Feb 17 '22 16:02 croesnick

Ich think this will be a quite heavy breaking change. As far as I have seen, there is no possibility to provide a custom layout within this comment box.

Another Idea could be to have this in addition for making fast comments, which can be edited in the current editor afterwards and assigned to categories etc.

Multiple comments could be handled in the current data structure by es special escape sequence. But maybe it would be the best to refactor everything including the data model and provide a completely new version / plugin

d-koppenhagen avatar Feb 18 '22 08:02 d-koppenhagen