Daniel Cameron

Results 124 comments of Daniel Cameron

Switching to CompleteableFutures will remove some of the sleeps, but not all. Note that even with CompleteableFutures, the code still needs a review for deadlocks and race conditions, although the...

@yfarjoun @lbergelson refactored so that all background processing tasks are CompletableFutures scheduled from the foreground thread. This version should be much simpler to code review. I've split the refactoring to...

Back to you @lbergelson

> Extended the README / documentation, if necessary Is there a README / documentation with all the settings exposed through `Defaults.java`? This PR now exposes the threadpool size through a...

@lbergelson @yfarjoun Any update on this PR?

Fixes in; updated to latest master

Great news. Any chance of including VCFv4.4 in scope near the end? There's quite a few SV changes in 4.4 that if you're designing a better VCF API it would...

Also, is there a plan for community engagement when drafting the APIs? I'd definitely like to contribute to any htsjdk API extensions that treat VCF symbolic alleles as first-class citizens.

For others encountering this issue: a workaround is to mount the bucket using gcs-fuse so it presents as a normal file system.

As of VCF 4.3 encoding is explicit: > The character encoding of VCF files is UTF-8. Newlines are also explicit: > Line separators must be CR+LF or LF